Fix #14206 --showtime does not account for addons #7904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. As an improvement the time could also be collected for the individual addons. |
|
as a start LGTM.. I have some small nits.. like "cancell" should be "cancel". I would like that we reuse this timer for the "--showtime=file-total" output also so a different class name would be better. |
olabetskyi
commented
Oct 28, 2025
| #include <algorithm> | ||
| #include <array> | ||
| #include <cassert> | ||
| #include <chrono> |
There was a problem hiding this comment.
we include it in the timer now
danmar
reviewed
Oct 28, 2025
danmar
reviewed
Oct 29, 2025
danmar
reviewed
Oct 29, 2025
danmar
reviewed
Oct 30, 2025
olabetskyi
commented
Oct 30, 2025
olabetskyi
commented
Oct 30, 2025
|
danmar
reviewed
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.